Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#147]Convert to Kotlin- data/remote/model/NoteRemote.java #193

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

OmneyaOsman
Copy link
Contributor

1-Add new data kotlin class NoteRemote in data/remote/model package with fields provided in NoteRemote.java but in kotlin .
2-remove NoteRemote.java

Vitor Poncell and others added 2 commits October 15, 2019 13:48
Added message when there is no network connection
1-Add new data kotlin class NoteRemote in data/remote/model package with fields provided in NoteRemote.java but in kotlin .
2-remove NoteRemote.java
Copy link
Member

@CarlosRodrigo CarlosRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution!

it seems that you branched out from the wrong branch because there is a commit from another developer on this PR.

Could you please branch out from dev and push your changes again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants