Optimize json parsing

Micro optimizations in parsing
Docile-Alligator · May 14, 2023 · c8785d4 · c8785d4
1 parent 8f0f921
commit c8785d4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/app/src/main/java/ml/docilealligator/infinityforreddit/ParseSubscribedThing.java b/app/src/main/java/ml/docilealligator/infinityforreddit/ParseSubscribedThing.java
@@ -71,14 +71,14 @@ protected Void doInBackground(Void... voids) {
                     JSONObject data = children.getJSONObject(i).getJSONObject(JSONUtils.DATA_KEY);
                     String name = data.getString(JSONUtils.DISPLAY_NAME_KEY);
                     String bannerImageUrl = data.getString(JSONUtils.BANNER_BACKGROUND_IMAGE_KEY);
-                    if (bannerImageUrl.equals("") || bannerImageUrl.equals("null")) {
+                    if (bannerImageUrl.isEmpty() || bannerImageUrl.equals("null")) {
                         bannerImageUrl = data.getString(JSONUtils.BANNER_IMG_KEY);
                         if (bannerImageUrl.equals("null")) {
                             bannerImageUrl = "";
                         }
                     }
                     String iconUrl = data.getString(JSONUtils.COMMUNITY_ICON_KEY);
-                    if (iconUrl.equals("") || iconUrl.equals("null")) {
+                    if (iconUrl.isEmpty() || iconUrl.equals("null")) {
                         iconUrl = data.getString(JSONUtils.ICON_IMG_KEY);
                         if (iconUrl.equals("null")) {
                             iconUrl = "";

diff --git a/app/src/main/java/ml/docilealligator/infinityforreddit/post/ParsePost.java b/app/src/main/java/ml/docilealligator/infinityforreddit/post/ParsePost.java
@@ -178,7 +178,7 @@ public static Post parseBasicData(JSONObject data) throws JSONException {
             flair = postFlairHTMLBuilder.toString();
         }
 
-        if (flair.equals("") && data.has(JSONUtils.LINK_FLAIR_TEXT_KEY) && !data.isNull(JSONUtils.LINK_FLAIR_TEXT_KEY)) {
+        if (flair.isEmpty() && !data.isNull(JSONUtils.LINK_FLAIR_TEXT_KEY)) {
             flair = data.getString(JSONUtils.LINK_FLAIR_TEXT_KEY);
         }
 
@@ -640,15 +640,8 @@ private static Post parseData(JSONObject data, String permalink, String id, Stri
                     }
 
                     JSONObject galleryItem = galleryIdsArray.getJSONObject(i);
-                    String galleryItemCaption = "";
-                    String galleryItemCaptionUrl = "";
-                    if (galleryItem.has(JSONUtils.CAPTION_KEY)) {
-                        galleryItemCaption = galleryItem.getString(JSONUtils.CAPTION_KEY).trim();
-                    }
-
-                    if (galleryItem.has(JSONUtils.CAPTION_URL_KEY)) {
-                        galleryItemCaptionUrl = galleryItem.getString(JSONUtils.CAPTION_URL_KEY).trim();
-                    }
+                    String galleryItemCaption = galleryItem.optString(JSONUtils.CAPTION_KEY);
+                    String galleryItemCaptionUrl = galleryItem.optString(JSONUtils.CAPTION_URL_KEY).trim();
 
                     if (previews.isEmpty() && (mimeType.contains("jpg") || mimeType.contains("png"))) {
                         previews.add(new Post.Preview(galleryItemUrl, singleGalleryObject.getJSONObject(JSONUtils.S_KEY).getInt(JSONUtils.X_KEY),
@@ -714,7 +707,7 @@ private static Post parseData(JSONObject data, String permalink, String id, Stri
                     if (selfTextPlain.length() > 250) {
                         selfTextPlain = selfTextPlain.substring(0, 250);
                     }
-                    if (!selfText.equals("")) {
+                    if (!selfText.isEmpty()) {
                         Pattern p = Pattern.compile(">!.+!<");
                         Matcher m = p.matcher(selfText.substring(0, Math.min(selfText.length(), 400)));
                         if (m.find()) {

diff --git a/app/src/main/java/ml/docilealligator/infinityforreddit/subreddit/ParseSubredditData.java b/app/src/main/java/ml/docilealligator/infinityforreddit/subreddit/ParseSubredditData.java
@@ -41,7 +41,7 @@ private static SubredditData parseSubredditData(JSONObject subredditDataJsonObje
         } else {
             bannerImageUrl = subredditDataJsonObject.getString(JSONUtils.BANNER_BACKGROUND_IMAGE_KEY);
         }
-        if (bannerImageUrl.equals("") && !subredditDataJsonObject.isNull(JSONUtils.BANNER_IMG_KEY)) {
+        if (bannerImageUrl.isEmpty() && !subredditDataJsonObject.isNull(JSONUtils.BANNER_IMG_KEY)) {
             bannerImageUrl = subredditDataJsonObject.getString(JSONUtils.BANNER_IMG_KEY);
         }
 
@@ -51,7 +51,7 @@ private static SubredditData parseSubredditData(JSONObject subredditDataJsonObje
         } else {
             iconUrl = subredditDataJsonObject.getString(JSONUtils.COMMUNITY_ICON_KEY);
         }
-        if (iconUrl.equals("") && !subredditDataJsonObject.isNull(JSONUtils.ICON_IMG_KEY)) {
+        if (iconUrl.isEmpty() && !subredditDataJsonObject.isNull(JSONUtils.ICON_IMG_KEY)) {
             iconUrl = subredditDataJsonObject.getString(JSONUtils.ICON_IMG_KEY);
         }
 

diff --git a/app/src/main/java/ml/docilealligator/infinityforreddit/user/ParseUserData.java b/app/src/main/java/ml/docilealligator/infinityforreddit/user/ParseUserData.java
@@ -31,7 +31,7 @@ private static UserData parseUserDataBase(JSONObject userDataJson, boolean parse
         String iconImageUrl = userDataJson.getString(JSONUtils.ICON_IMG_KEY);
         String bannerImageUrl = "";
         boolean canBeFollowed;
-        if (userDataJson.has(JSONUtils.SUBREDDIT_KEY) && !userDataJson.isNull(JSONUtils.SUBREDDIT_KEY)) {
+        if (!userDataJson.isNull(JSONUtils.SUBREDDIT_KEY)) {
             bannerImageUrl = userDataJson.getJSONObject(JSONUtils.SUBREDDIT_KEY).getString(JSONUtils.BANNER_IMG_KEY);
             canBeFollowed = true;
         } else {