Show collapsed comment count when toolbar closed. #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users that leave comment toolbars collapsed by default for space reasons, the need to see the child comment count (or that a comment has children) is still present.
This PR shows the child comment count similarly to the vote count that shows up when a comment toolbar is collapsed.
There's been some suggestions around for it, eg #869 and https://www.reddit.com/r/Infinity_For_Reddit/comments/106e3cs/cant_see_number_of_child_comments_unless_comment/
I'm not sure what the feeling would be for something like this. It might need a different preference. However, a different preference would be confusing with the 'Always Show the Number of Child Comments' preference, so perhaps it should behind that existing preference?
Glad to hear thoughts, thanks.