Changed the way read posts are handled to support an arbitrary read posts limit #1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, read posts are loaded from the room database to memory in a
List<ReadPost>
during usage. The list is used to mark posts being loaded as read during post parsing. Due to performance reasons (saving the state of the list), the read posts database is limited to 500 entries.Changes
Change how we handle read posts when new posts are loaded.
We can instead mark loaded posts as read directly from the db.
List<ReadPost>
to handle read posts, we useReadPostsListInterface
, which contains the necessary methods for marking loaded posts as read.ReadPostsListInterface
(calledReadPostsList
) just usesReadPostDao
.parsePostSync()
to work with the newReadPostsListInterface
instead.Since read posts are not loaded to memory anymore, we can now set an arbitrary read posts limit.
Add a setting to customize the read post limit