Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ESM #38

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Feature: ESM #38

wants to merge 24 commits into from

Conversation

larslaade
Copy link
Contributor

@larslaade larslaade commented Sep 1, 2022 •
edited
Loading

Hi,

here is my PR for jsb as an ES module. Fixes #37

  • Code uses import/export
  • Rollup as a Builder
  • Remove internal RequireJS support
  • Remove domready
  • Update test cases
  • Readme updated
  • Typescript type definitions

Breaking changes

  • BREAKING: removed internal RequireJS-Support
  • BREAKING: changed parameter order on the "on"-function
  • BREAKING: removed applyBehaviour on the dom-ready-event

@larslaade larslaade marked this pull request as ready for review September 29, 2022 07:24
@larslaade larslaade changed the title Feature: ESM Feature: ESM, Fixes #37 Oct 31, 2022
@larslaade larslaade changed the title Feature: ESM, Fixes #37 Feature: ESM Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES module
1 participant
@larslaade