Fix the GitHub Actions build #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shx` is present in `package.json`.
By adding node.js and npm to the esp-idf container. Build different targets in a matrix. Fixes DroneBridge#79.
|
Sorry for the late reply! I was busy with other stuff. I'll merge right away! I trust you on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding node.js and npm to the esp-idf container.
Build different targets in a matrix.
Fixes #79.
Successful run here: https://github.com/mmalecki/DroneBridge-ESP32/actions/runs/9264073314
An alternative implementation would be to avoid building the
frontendtarget if the output directory is already present, but that could lead to stale build outputs when developing. Let me know what you think, and sorry for breaking this in the first place!