Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seed dispersal initialization option. #352

Closed
chaukap opened this issue Jul 15, 2019 · 2 comments
Closed

seed dispersal initialization option. #352

chaukap opened this issue Jul 15, 2019 · 2 comments
Assignees
@chaukap
Labels
bug
Milestone
Seed Dispersal

Comments

@chaukap
Copy link
Contributor

chaukap commented Jul 15, 2019 •
edited
Loading

The user should be able to initialize the plot using seed dispersal. Commit 6a77ca6 added a new function called _run_seed_initialization which is implemented in the code, but it currently does nothing. Once we have a plan for implementing seed dispersal _run_seed_initialization needs to be finished.

Note: This issue addresses initialization using seed dispersal. For information on seed dispersal during the simulation see issue #309.
@chaukap chaukap added the bug label Jul 15, 2019
@chaukap chaukap added this to the gridded_code milestone Jul 15, 2019
@chaukap chaukap self-assigned this Jul 15, 2019
@chaukap chaukap changed the title Added seed dispersal initialization option. Add seed dispersal initialization option. Jul 15, 2019
chaukap pushed a commit that referenced this issue Jul 22, 2019
Created seed dispersal module (.c and .h files)
c6dd45b 
This commit affects issues #355, #353, #352, and #309.
I moved all code associated with seed dispersal into it's own file. This way it can potentially be added to non-gridded mode, not to mention that this makes the code much more readable.

In ST_grid.c:
* removed declarations and definitions for _cell_dist, _init_seed_dispersal and _do_seed_dispersal. They are now defined in ST_seedDispersal.c. _init_seed_dispersal has been renamed to initDispersalParameters and _do_seed_dispersal has been renamed to disperseSeeds.

In ST_grid.h:
* Removed declaration of UseSeedDispersal flag. It has been moved to ST_seedDispersal.h.

In ST_main.c:
* added an include statement for the new .h file.

In ST_species.c:
* added an include statement for the new .h file.

In ST_stats.c:
* added an include statement for the new .h file.

In ST_seedDispersal.h:
* Created the file.
* Declared the two functions we want to export.
* Declared the UseSeedDispersal flag.

In ST_seedDispersal.c:
* Declared _cell_dist (formerly in ST_grid.c)
* Created two new functions (_do_bulk_dispersal and _do_precise_dispersal) to be written later.
* Added definition for initDispersalParameters (formerly _init_seed_dispersal)
* Added definition for disperseSeeds (formerly _do_seed_dispersal)
@chaukap chaukap modified the milestones: gridded_code, Seed_Dispersal Jul 28, 2019
@kpalmqui
Copy link
Member

@chaukap We have decided we currently do not need this initialization. Thus we need to remove any remaining seed initialization code and close this issue when that is complete.

chaukap pushed a commit that referenced this issue Jan 30, 2020
Removed seed dispersal initialization option
20dc3d2 
(Issue #352)
With this commit all of the infrastructure put in place to initialize with seed dispersal is now gone.
@chaukap chaukap changed the title Add seed dispersal initialization option. seed dispersal initialization option. Jan 30, 2020
@chaukap
Copy link
Contributor Author

chaukap commented Jan 30, 2020

Seed dispersal initialization was born and died in this issue. With commit 20dc3d2 it is now completely removed. This issue is therefore resolved.

@chaukap chaukap closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaukap chaukap

Labels
bug
Projects
None yet
Milestone
Seed Dispersal
Development

No branches or pull requests
2 participants
@kpalmqui @chaukap