Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul seed dispersal output file. #353

Closed
chaukap opened this issue Jul 15, 2019 · 5 comments
Closed

Overhaul seed dispersal output file. #353

chaukap opened this issue Jul 15, 2019 · 5 comments
Assignees

Comments

@chaukap
Copy link
Contributor

chaukap commented Jul 15, 2019

The output file for seed dispersal info needs to be overhauled once we have seed dispersal working.

@chaukap chaukap added this to the gridded_code milestone Jul 15, 2019
@chaukap chaukap self-assigned this Jul 15, 2019
chaukap pushed a commit that referenced this issue Jul 22, 2019
This commit affects issues #355, #353, #352, and #309.
I moved all code associated with seed dispersal into it's own file. This way it can potentially be added to non-gridded mode, not to mention that this makes the code much more readable.

In ST_grid.c:
* removed declarations and definitions for _cell_dist, _init_seed_dispersal and _do_seed_dispersal. They are now defined in ST_seedDispersal.c. _init_seed_dispersal has been renamed to initDispersalParameters and _do_seed_dispersal has been renamed to disperseSeeds.

In ST_grid.h:
* Removed declaration of UseSeedDispersal flag. It has been moved to ST_seedDispersal.h.

In ST_main.c:
* added an include statement for the new .h file.

In ST_species.c:
* added an include statement for the new .h file.

In ST_stats.c:
* added an include statement for the new .h file.

In ST_seedDispersal.h:
* Created the file.
* Declared the two functions we want to export.
* Declared the UseSeedDispersal flag.

In ST_seedDispersal.c:
* Declared _cell_dist (formerly in ST_grid.c)
* Created two new functions (_do_bulk_dispersal and _do_precise_dispersal) to be written later.
* Added definition for initDispersalParameters (formerly _init_seed_dispersal)
* Added definition for disperseSeeds (formerly _do_seed_dispersal)
@chaukap chaukap modified the milestones: gridded_code, Seed_Dispersal Jul 28, 2019
@chaukap
Copy link
Contributor Author

chaukap commented Jan 28, 2020

I'm going to begin working on this issue now. To keep this module decoupled I will declare a function called outputDispersalStatistics in ST_seedDispersal.h and define it in ST_seedDispersal.c.

I'm not sure what information we are looking for, so @kpalmqui if you have any suggestions let me know. I'll start with the easy part, which is outputting for which years seedsPresent was TRUE for each cell.

chaukap referenced this issue Jan 29, 2020
This function will output every dispersal event (an instance of one cell giving seeds to another cell) in a single CSV file.
@chaukap
Copy link
Contributor Author

chaukap commented Jan 29, 2020

@kpalmqui The commit above will output a CSV with an entry for every instance of once cell distributing seeds to a neighboring cell. If we need something more fine grained please let me know.

@kpalmqui
Copy link
Member

@chaukap my only concern here is that these files will get very large (tons of rows) when multiple species have seed dispersal on, when a larger landscape of cells are run, and when multiple interations are run.

What do you think of potentially creating individual files for each grid cell (consistent with the other output files) where each file would focus on summarizing info for the "receiver" cell.

@chaukap
Copy link
Contributor Author

chaukap commented Jan 30, 2020

@kpalmqui I can do that!

chaukap pushed a commit that referenced this issue Jan 31, 2020
@chaukap
Copy link
Contributor Author

chaukap commented Feb 12, 2020

We have decided that the format of the output files is sufficient and there is no need to output the probability of dispersal for every cell for every year. Therefore this issue is completed.

@chaukap chaukap closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants