Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allow_growth field in SpeciesType struct. #445

Closed
chaukap opened this issue Jan 28, 2020 · 4 comments
Closed

Remove allow_growth field in SpeciesType struct. #445

chaukap opened this issue Jan 28, 2020 · 4 comments
Assignees

Comments

@chaukap
Copy link
Contributor

chaukap commented Jan 28, 2020

Species[sp]->allow_growth is a seed dispersal specific variable that is unnecessary in the current implementation.

The documentation, a hold over from DLM, reads

Seed dispersal only- whether to allow growth for the current year.

Which makes no sense given our implementation of seed dispersal.

It is set to TRUE in _species_init then never modified again. Therefore, it it useless and can be removed.

@chaukap chaukap added this to the Seed Dispersal milestone Jan 28, 2020
@chaukap chaukap self-assigned this Jan 28, 2020
chaukap pushed a commit that referenced this issue Jan 28, 2020
@kpalmqui
Copy link
Member

@chaukap thanks! looks like we also need to remove the mention of allow_growth in the DLM_change_log.txt file.

@chaukap
Copy link
Contributor Author

chaukap commented Jan 29, 2020

@kpalmqui My vote is to delete the file DLM_change_log.txt most of the changes that are mentioned in the file have been undone, not just allow_growth, plus I don't think reading this file would help any future programmers understand the program.

@kpalmqui
Copy link
Member

@chaukap I would like to briefly review it before we delete it. Thanks!

@chaukap
Copy link
Contributor Author

chaukap commented Jan 30, 2020

After discussion we have decided to remove DLM_change_log.txt. I opened issue #450 to address the removal.

@chaukap chaukap closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants