Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rate of dispersal calculation based on maximum height (HMAX) instead of actual height of the tallest plant #505

Closed
kpalmqui opened this issue Mar 18, 2021 · 2 comments
Assignees

Comments

@kpalmqui
Copy link
Member

kpalmqui commented Mar 18, 2021

Current implementation:

float _rateOfDispersal(float PMD, float height, float maxDistance) {
       return log(PMD) * height / maxDistance;
 }

Proposed implementation:

float _rateOfDispersal(float PMD, float maxHeight, float maxDistance) {
return (log(PMD) * maxHeight) / maxDistance;
}
@kpalmqui kpalmqui added this to the Seed Dispersal milestone Mar 18, 2021
@kpalmqui kpalmqui self-assigned this Mar 18, 2021
@kpalmqui
Copy link
Member Author

kpalmqui added a commit that referenced this issue 35 seconds ago
@kpalmqui
Calculation of rate of dispersal now based on maximum height, instead… …
deb44ad
… of actual height of the largest individual, issue #507

  • fixed error on line 21
  • function is now based on maxHeight instead of height (which is the height of the largest established individual)
  • updated equation to ensure order of operations

@kpalmqui
Copy link
Member Author

resolved by above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant