Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate maxCells - set but not used #515

Closed
kpalmqui opened this issue Jan 18, 2022 · 2 comments
Closed

Investigate maxCells - set but not used #515

kpalmqui opened this issue Jan 18, 2022 · 2 comments
Assignees
@alexisBelt
Milestone
Seed Dispersal

Comments

@kpalmqui
Copy link
Member

Look into maxCells and whether it is needed. It is being defined but never used.
@kpalmqui kpalmqui added this to the Seed Dispersal milestone Jan 18, 2022
@kpalmqui kpalmqui assigned alexisBelt and unassigned mnovo323 Jul 16, 2023
@alexisBelt
Copy link
Contributor

maxCells seems to calculate the max number of cells that can disperse seeds (a guess because there's no documentation). It's given a value but never used. The program still runs gridded and un-gridded mode if taken out. MAXDP is initialized also, but is only used to calculate maxCells, so it doesn't seem needed either.

@alexisBelt
Copy link
Contributor

It seems that the Seed_Dispersal branch has already updated this problem. The whole of the void initDispersalParameters(void) function has been deleted, taking maxCells and MAXDP with it. This was done in 84d0a4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexisBelt alexisBelt

Labels
None yet
Projects
None yet
Milestone
Seed Dispersal
Development

No branches or pull requests
3 participants
@kpalmqui @mnovo323 @alexisBelt