Add testing radio button with listener #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two mockups modified for testing mouse clicking with metakeys pressed.
basilevs
suggested changes
Apr 20, 2020
| radioButtons[5].setText("Choice 5"); | ||
|
|
||
| radioButtons[5].addSelectionListener(new SelectionAdapter() { | ||
| @Override |
|
|
||
| private void selectionChange() { | ||
| boolean buttonSelected = radioButtons[5].getSelection(); | ||
| radioButtons[1].setEnabled(!buttonSelected); |
There was a problem hiding this comment.
Unintended side-effect. We are testing, that a button received deselection event, if listener itself produces more events, this may lead to false negatives.
basilevs
suggested changes
Apr 21, 2020
|
|
||
| private void selectionChange() { | ||
| boolean buttonSelected = radioButtons[5].getSelection(); | ||
| text.setText(buttonSelected ? "selected" : ""); |
There was a problem hiding this comment.
A would recommend not use empty string here. "unselected" would be better visible on screenshots and easier to assert.
| @@ -6,8 +6,8 @@ Element-Type: testcase | |||
| Element-Version: 3.0 | |||
| External-Reference: | |||
| Id: _UPfZgJa6EeK184kZHmPTQQ | |||
| Runtime-Version: 1.5.6.qualifier | |||
| Save-Time: 4/1/15 12:04 PM | |||
| Runtime-Version: 2.5.1.202004201035 | |||
There was a problem hiding this comment.
Where is the test for text change when a button is deselected?
basilevs
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.