Avoid duplicate access token parsing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to parse the access token in the DPoPJwtBearerEvents, since the handler already parses and makes the claims available in the context.
bhazen
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to parse the access token in the DPoPJwtBearerEvents, since the handler already parses and makes the claims available in the context. By relying on those claims, we improve both performance (no allocation of an extra parser, no duplication of parsing work) and functionality (claims from a JWE are available).
This PR is based on @jpda's work using the claims in the context. I go a little further by just not parsing at all. The reason to create a new PR is to rebase the changes onto main, where CI pipeline updates have been merged that are needed for the build.