Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe absoluterefreshtokenlifetime set to 0 in reference/models/client #526

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

RolandGuijt
Copy link
Contributor

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-526.eastus2.azurestaticapps.net

Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the behavior when sliding is disabled and lifetime is 0? I actually forget if that means no expiration or if it is a useless token that is created already expired.

@RolandGuijt
Copy link
Contributor Author

If:
RefreshTokenExpiration = TokenExpiration.Absolute, AbsoluteRefreshTokenLifetime = 0

Then a refresh token will be issued but it has the same effect as having no refresh token at all :-)
Do you think I need to add that?

@josephdecock
Copy link
Member

Yes, I think we should expand both the absolute and sliding expiration to explain how they interact and what happens at the extremes.

Copy link

github-actions bot commented Oct 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-526.eastus2.azurestaticapps.net

@RolandGuijt
Copy link
Contributor Author

@josephdecock Added that and restructured a bit to keep it readable.

@josephdecock josephdecock merged commit a687942 into main Oct 2, 2024
2 checks passed
@josephdecock josephdecock deleted the roland/absoluterefreshtokenlifetime0 branch October 2, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants