Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThrowIfNullOrWhiteSpace for type in IdentityProvider #1675

Conversation

SimonCropp
Copy link
Contributor

I assume empty and whitespace is invalid for type?

Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - I can't picture anyone ever correctly configuring an IdentityProvider with a type that was just white space.

@josephdecock josephdecock merged commit f753fe1 into DuendeSoftware:main Jan 28, 2025
@josephdecock josephdecock added this to the is-7.2.0 milestone Jan 28, 2025
@SimonCropp SimonCropp deleted the throw-ThrowIfNullOrWhiteSpace-for-type-in-IdentityProvider branch January 28, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants