fix(is): LicenseUsageSummary resolution #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed usage in the main host of the LicenseUsageSummary so that it is resolved at shutdown properly.
josephdecock
force-pushed
the
jmdc/license-summary-resolution
branch
from
57eaaeb to
0c6eb67
Compare
hosts/main/Program.cs
Outdated
| { | ||
| var usage = app.Services.GetRequiredService<LicenseUsageSummary>(); | ||
| Console.Write(Summary(usage)); | ||
| Console.ReadKey(); |
There was a problem hiding this comment.
While this is a demo, the idea of having Console.ReadKey here might be problematic for folks copying and pasting this into a production application. Should we leave a comment about this blocking?
There was a problem hiding this comment.
Hmm, I added the readkey because on my machine (vscode on windows) the host runs in an external terminal which is closed as soon as the app exits. We could wrap either the whole summary or just the readkey in an if (app.Environment.IsDevelopment())?
There was a problem hiding this comment.
That could work as well.
khalidabuhakmeh
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed usage in the main host of the LicenseUsageSummary so that it is resolved at shutdown properly.