Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect 'for' attribute in userCode inputs #1712

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

khalidabuhakmeh
Copy link
Contributor

Replaced the incorrect 'for' attribute with 'id' for the userCode input fields across multiple Index.cshtml files to ensure proper HTML semantics and accessibility. This change aligns the input fields with their respective labels.

Replaced the incorrect 'for' attribute with 'id' for the userCode input fields across multiple Index.cshtml files to ensure proper HTML semantics and accessibility. This change aligns the input fields with their respective labels.
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the same changes in the templates subdirectory.

Replaced the erroneous "for" attribute with the correct "id" attribute in the userCode input fields across multiple Device/Index.cshtml files in the templates directory.
@khalidabuhakmeh khalidabuhakmeh merged commit aeb1fc3 into main Jan 8, 2025
6 checks passed
@damianh damianh deleted the ka-fix-userCode-id branch February 4, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants