Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate conda cache directories in CI #217

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

altheaden
Copy link
Collaborator

This PR updates the build workflow to use separate directories for each python version for conda caching. Issues with this seem to have been crashing CI runs lately.

I also fixed a bug in the docs workflow, where it was referring to a nonexistent python version matrix (likely a remnant of copying from the build workflow). Instead, I set this to be an environment variable called PYTHON_VERSION which will allow us to more easily specify and update the python version we use for the documentation without having to change it in a couple different places. I also copied this convention into the pre-commit update workflow for consistency.

Checklist

  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added the ci Changes affect github actions CI label Jan 16, 2025
@altheaden
Copy link
Collaborator Author

Testing

I ran all CI workflows on my fork and verified that I did see the correct python versions, and also that the cache directories were set up correctly. I also checked that the documentation appears to have been built and deployed correctly. All checks passed.

@altheaden altheaden requested a review from xylar January 16, 2025 20:57
@altheaden
Copy link
Collaborator Author

@xylar I made one additional change in the CI here that I'd like to repeat across other repos as well. Can you verify that the changes I made here are in line with what you'd like? If so, I will go ahead and implement this on other repos.
Most of the repos I've been working on have fail-fast already set so that's why it's not present here and might not be present in many others either.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@xylar
Copy link
Collaborator

xylar commented Jan 16, 2025

@xylar I made one additional change in the CI here that I'd like to repeat across other repos as well. Can you verify that the changes I made here are in line with what you'd like? If so, I will go ahead and implement this on other repos.

Yes, perfect. The more we can bundle into one PR, the better to save us time.

Most of the repos I've been working on have fail-fast already set so that's why it's not present here and might not be present in many others either.

Okay, good to know. I noticed it on Compass and it was pretty annoying so I wanted to catch it wherever it's still on.

@xylar xylar merged commit 9f99253 into E3SM-Project:main Jan 17, 2025
6 checks passed
@xylar xylar deleted the fix-conda-cache branch January 17, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants