Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This patch fixes the pipeline when using a reference genome #10

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

mberacochea
Copy link
Member

This fixes the decontamination process when a secondary reference is provided. It also publishes the BLASTN decontamination files (and adds the meta2) as part of the name to distinguish them.

@mberacochea mberacochea added the bug Something isn't working label Jun 26, 2024
@mberacochea mberacochea self-assigned this Jun 26, 2024
@mberacochea mberacochea requested a review from Ge94 June 26, 2024 08:30
conf/modules.config Show resolved Hide resolved
@mberacochea
Copy link
Member Author

Unit tests are failling because the ENA FTP seems to be flaky

Copy link
Member

@Ge94 Ge94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it separately and it seemed to be running fine! We should probably add a few tests for decontamination with/without extra ref genome... I can look into this in a few days

@mberacochea mberacochea marked this pull request as ready for review June 26, 2024 14:53
@mberacochea mberacochea merged commit cebe411 into main Jun 26, 2024
1 check failed
@mberacochea mberacochea deleted the bugfix/decontaminate-with-human-and-reference branch June 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants