-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in miassembler #31
Conversation
Solving the following bugs:
I have added a filtering step to short_reads_assembly_qc.nf, after the host cleaning, which counts the number of contigs and only generates cleaned_contigs.fa.gz if the threshold is met - I had to remove the extra metadata generated during this quality check for the rest of the pipeline to run. I've set the default as 2 contigs so this fix solves problem 1&2. I think there was still an issue with which file was being published in PUBLISH_CLEANED_CONTIGS. It was filtered_contigs which I think meant any non-human host cleaning still wasn't being used. Please check that this logic makes sense in my changes! I've added another if statement to short_reads_assembly_qc.nf so if no reference is specified it still uses the length and human filtered outputs. Again please check this logic. The qc_failed_runs csv generated now includes samples that fail the assembly qc check I've added. We could split this into another csv if we wanted this to be separate from the read qc output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jmattock5. It looks pretty good to me. I added some nitpicky comments; I've learned that having clear names makes it easier to follow the code, so I've included some suggestions to improve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @jmattock5 !
Thanks for your comments! I've made all the changes you suggested but for two, please look at my comments for justification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🏅 @jmattock5
Draft PR for numerous bugs to be fixed in miassembler: