Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hifiadapterfilt branch #76

Merged
merged 7 commits into from
Jan 29, 2025
Merged

New hifiadapterfilt branch #76

merged 7 commits into from
Jan 29, 2025

Conversation

Ge94
Copy link
Member

@Ge94 Ge94 commented Jan 28, 2025

The previous branch was setup with the old github actions, causing conflicts between nf-core linters and github actions linters.

Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looks pretty good to me, I left you a couple of small comments

modules/ebi-metagenomics/hifiadapterfilt/main.nf Outdated Show resolved Hide resolved
@Ge94 Ge94 requested a review from mberacochea January 28, 2025 17:23
Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.. I left a couple of minor comments :)

modules/ebi-metagenomics/hifiadapterfilt/main.nf Outdated Show resolved Hide resolved
modules/ebi-metagenomics/hifiadapterfilt/main.nf Outdated Show resolved Hide resolved
@Ge94 Ge94 requested a review from mberacochea January 28, 2025 18:49
Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@Ge94 Ge94 merged commit e7cdcab into main Jan 29, 2025
7 checks passed
@Ge94 Ge94 deleted the hifiadapterfilt_v2 branch January 29, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants