Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 36: Improve genotype ID algorithm #37

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

apriltuesday
Copy link
Collaborator

@apriltuesday apriltuesday commented Apr 3, 2024

Closes #36
Also includes the notebook for #21

Example evidence strings for rs72549309 (dbsnp, pgkb)

Reference only:

  "datasourceId": "pharmgkb",
  "datasourceVersion": "2024-04-05",
  "datatypeId": "clinical_annotation",
  "studyId": "1447989678",
  "evidenceLevel": "1A",
  "literature": [
    "10071185",
    "24648345"
  ],
  "genotype": "ATGA/ATGA",
  "genotypeAnnotationText": "The del allele of rs72549309 is assigned no function by CPIC. Patients with the ATGA/ATGA genotype may have increased DPYD activity as compared to those with the ATGA/del or del/del genotypes. Other genetic and clinical factors may also influence catalytic activity of DPYD.",
  "drugFromSource": "fluorouracil",
  "drugFromSourceId": "CHEBI_46345",
  "pgxCategory": "other",
  "genotypeId": "1_97740410_GATGA_GATGA,GATGA",
  "variantRsId": "rs72549309",
  "variantFunctionalConsequenceId": "SO_0002073",
  "targetFromSourceId": "ENSG00000188641"
}

With variant:

{
  "datasourceId": "pharmgkb",
  "datasourceVersion": "2024-04-05",
  "datatypeId": "clinical_annotation",
  "studyId": "1447989678",
  "evidenceLevel": "1A",
  "literature": [
    "10071185",
    "24648345"
  ],
  "genotype": "ATGA/del",
  "genotypeAnnotationText": "The del allele of rs72549309 is assigned no function by CPIC. Patients with the ATGA/del genotype may have decreased DPYD activity as compared to those with the ATGA/ATGA genotype. Other genetic and clinical factors may also influence catalytic activity of DPYD.",
  "drugFromSource": "fluorouracil",
  "drugFromSourceId": "CHEBI_46345",
  "pgxCategory": "other",
  "genotypeId": "1_97740410_GATGA_G,GATGA",
  "variantRsId": "rs72549309",
  "variantFunctionalConsequenceId": "SO_0001589",
  "targetFromSourceId": "ENSG00000188641"
}

@apriltuesday apriltuesday marked this pull request as ready for review April 11, 2024 10:59
@apriltuesday apriltuesday requested a review from tcezard April 11, 2024 10:59
@apriltuesday apriltuesday self-assigned this Apr 11, 2024
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. The normalisation is also very well explained.

tests/test_variant_coordinates.py Show resolved Hide resolved
@apriltuesday apriltuesday merged commit 2e91099 into EBIvariation:main Apr 12, 2024
1 check passed
@apriltuesday apriltuesday deleted the issue-21 branch April 12, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gene coverage via improvements to genotype ID algorithm
2 participants