Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: FS Separator #2424

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Windows: FS Separator #2424

merged 2 commits into from
Oct 16, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 14, 2021

Fix the openPMD warning:

Filepaths on WINDOWS platforms may not contain slashes '/'!
Replacing with backslashes '\' unconditionally!

Related to #1776
Depends on AMReX-Codes/amrex#2405

@ax3l ax3l added component: openPMD openPMD I/O warning A compiler or tool warning component: diagnostics all types of outputs labels Oct 14, 2021
@ax3l ax3l force-pushed the topic-fsSepWin branch 2 times, most recently from 4459bc9 to d72b7a7 Compare October 14, 2021 22:18
@ax3l ax3l requested review from RemiLehe and dpgrote October 15, 2021 17:28
ax3l added 2 commits October 15, 2021 11:23
Fix the openPMD warning:
```
Filepaths on WINDOWS platforms may not contain slashes '/'!
Replacing with backslashes '\' unconditionally!
```
We might also be able to silence the warning in openPMD-api later on.
Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this looks good, thanks!

@ax3l ax3l enabled auto-merge (squash) October 15, 2021 22:16
@ax3l ax3l merged commit db7e6f9 into ECP-WarpX:development Oct 16, 2021
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 29, 2021
* Windows: FS Separator

Fix the openPMD warning:
```
Filepaths on WINDOWS platforms may not contain slashes '/'!
Replacing with backslashes '\' unconditionally!
```

* openPMD: Replace just for Series

We might also be able to silence the warning in openPMD-api later on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs component: openPMD openPMD I/O warning A compiler or tool warning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants