Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Glue2.1 JSON rendering fixes #275

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Jan 14, 2025

Summary

Fixes issues found now that we are actually consuming the json info:

  • when producing JSON GLUE, "Share" was populated like a list of lists, instead of a list of dicts, which is what we are using elsewhere. This just makes it work like all the other fields
  • Issue with INFN-BARI and JSON publishing #276: use the actual glue img_obj for associations instead of the OpenStack object
  • Fix the Associations for the service object

Related issue : #276

@enolfc
Copy link
Contributor Author

enolfc commented Jan 14, 2025

arg, needs some update in the testing to really work :(

@enolfc enolfc changed the title fix: Shares is already a dict fix: Glue2.1 JSON rendering fixes Jan 14, 2025
@enolfc enolfc requested a review from gwarf January 15, 2025 11:32
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc enolfc merged commit 6fbbf1c into EGI-Federation:main Jan 15, 2025
5 checks passed
@enolfc enolfc deleted the shares-fix branch January 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants