-
Notifications
You must be signed in to change notification settings - Fork 3.8k
add code coverage host functions #10933
base: develop-boxed
Are you sure you want to change the base?
add code coverage host functions #10933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new host functions should only be added to eosio-tester and rodeos not nodeos.
I'm not sure its possible with only an eosio-tester modification. Tester intrinsics only appear to work with test contracts. The test contract uses a special framework which in turn calls the normal contracts. It also has to define main(), which normal contracts don't. So I don't believe our normal contracts can be compiled as test contracts so they can use pure tester intrisics. I have verified that the recent commit 7e6b809 works through the whole cycle,. and generates a reasonable code coverage report. We don't actually have to merge this in, we could keep it as a separate branch just for the purpose of using code coverage. |
…-EPE-1812_eos-vm-coverage-host-functions
@@ -16,10 +17,13 @@ class coverage_maps { | |||
|
|||
cov_map_t funcnt_map; | |||
cov_map_t linecnt_map; | |||
eosio::name T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
…-EPE-1812_eos-vm-coverage-host-functions
Change Description
Adds new host functions to support contract code coverage.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions