Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Itemfilter StyleOverride access to selectionlist #536

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

A-Behairi
Copy link
Collaborator

@A-Behairi A-Behairi commented Dec 18, 2023

Introducing noShadow property in eox-selectionlist that enables it's rendering without a shadow root and giving access for styleOverride property of the eox-itemfilter to reach eox-selectionlist in primary (not inline) mode.

@lubojr
Copy link
Member

lubojr commented Dec 19, 2023

Just to double check - this PR is going to fix the styleOverride for ItemFilter not working at the moment?

Storybook https://eox-a.github.io/EOxElements/?path=/docs/elements-eox-itemfilter--docs for ItemFilter does not interact anyhow to the changes of the styleOverride property or is the behavior inside storybook just a "nonreactivity" issue of the storybook itself?

@silvester-pari
Copy link
Collaborator

Just to double check - this PR is going to fix the styleOverride for ItemFilter not working at the moment?

Storybook https://eox-a.github.io/EOxElements/?path=/docs/elements-eox-itemfilter--docs for ItemFilter does not interact anyhow to the changes of the styleOverride property or is the behavior inside storybook just a "nonreactivity" issue of the storybook itself?

Yes and no - this PR fixes some styleOverride issues for the sub-component selectionlist, which currently isn't "reachable" for the override since it's located in a separate shadow root.

The non-reacting of the storybook example might be an other issue, could be that the styleOverride property is not yet reactive, means doesn't react on changes, only uses initial value.

Before investing too much effort into this, I'd like to come up with a good generic way for style overrides, see #325

@lubojr
Copy link
Member

lubojr commented Dec 20, 2023

OK. My concrete use case why I asked was that since ItemFilter 0.9.0 -> 0.12.0 the way how styleOverride works has changed (if I understand it correctly from filterOptions.styleOverride to property called styleOverride) but also the structure of HTML elements which compose the ItemFilter single select changed. Therefore current overrides for GTIF Domain images do not work anymore and I am struggling to get it back working in a branch eurodatacube/eodash#2427.

@A-Behairi A-Behairi marked this pull request as draft December 20, 2023 10:19
@A-Behairi A-Behairi marked this pull request as ready for review December 20, 2023 11:41
@silvester-pari silvester-pari merged commit 8620f93 into main Dec 20, 2023
3 checks passed
@silvester-pari silvester-pari deleted the itemfilter/fix/selectionlist-shadow-root branch December 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants