Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard names for tropopause_find #140

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Oct 18, 2024

Fixes ESCOMP/CAM-SIMA#308
Requires a companion PR in CAM-SIMA to update the standard name of tropp_slices there as well: ESCOMP/CAM-SIMA#329

@jimmielin jimmielin added the cleanup This issue indicates an opportunity for code cleanup. label Oct 18, 2024
@jimmielin jimmielin self-assigned this Oct 18, 2024
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I did have one request for the new standard name.

schemes/tropopause_find/tropopause_find.meta Outdated Show resolved Hide resolved
@jimmielin jimmielin changed the title Update tropp_slices standard name Update standard names for tropopause_find Dec 9, 2024
@jimmielin jimmielin requested a review from nusbaume December 9, 2024 21:06
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks @jimmielin!

@jimmielin
Copy link
Member Author

Regression tests passed (subject to existing failures) - no changes to baselines

derecho gnu

  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_held_suarez_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_after_coupler_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_before_coupler_derecho (Overall: PASS) details:
  SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho (Overall: PEND) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_gnu.cam-outfrq_se_cslam_analy_ic (Overall: PEND) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FHS94.derecho_gnu.cam-outfrq_se_cslam (Overall: PASS) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_gnu.cam-outfrq_se_cslam (Overall: PASS) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_gnu.cam-outfrq_se_cslam (Overall: PASS) details:

derecho intel
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_intel.cam-outfrq_held_suarez_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_intel.cam-outfrq_kessler_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_intel.cam-outfrq_tj2016_after_coupler_derecho (Overall: PASS) details:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_intel.cam-outfrq_tj2016_before_coupler_derecho (Overall: PASS) details:
  SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho (Overall: PEND) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_intel.cam-outfrq_se_cslam_analy_ic (Overall: PEND) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FHS94.derecho_intel.cam-outfrq_se_cslam (Overall: PASS) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam (Overall: PASS) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_intel.cam-outfrq_se_cslam (Overall: PASS) details:

Merging!

@jimmielin jimmielin merged commit 491e562 into ESCOMP:development Dec 16, 2024
3 checks passed
jimmielin added a commit that referenced this pull request Dec 31, 2024
Tag name (The PR title should also include the tag name):
`atmos_phys0_07_001`
Originator(s): @jimmielin

List all `development` PR URLs included in this PR and a short
description of each:
* Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze
* Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze
* Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin
* Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze
* Add constituent tendency updater #111 by @peverwhee
* Add cloud optical calculations for use in TUV-x #167 by @mattldawson
* Add initialize_constituents scheme #149 by @peverwhee
* Add diagnostics to TJ2016 test schemes #170 by @peverwhee
* update "radians" to "rad" #173 by @peverwhee
* Solar zenith angle and Earth-Sun distance #171 by @mattldawson
* Update standard names for tropopause_find #140 by @jimmielin
* Update surface albedo units #181 by @mattldawson
* don't set water species property for species that air_composition handles #185 by @peverwhee

List all test failures: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This issue indicates an opportunity for code cleanup.
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants