-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update standard names for tropopause_find #140
Update standard names for tropopause_find #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I did have one request for the new standard name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks @jimmielin!
Regression tests passed (subject to existing failures) - no changes to baselines
Merging! |
Tag name (The PR title should also include the tag name): `atmos_phys0_07_001` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze * Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze * Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin * Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze * Add constituent tendency updater #111 by @peverwhee * Add cloud optical calculations for use in TUV-x #167 by @mattldawson * Add initialize_constituents scheme #149 by @peverwhee * Add diagnostics to TJ2016 test schemes #170 by @peverwhee * update "radians" to "rad" #173 by @peverwhee * Solar zenith angle and Earth-Sun distance #171 by @mattldawson * Update standard names for tropopause_find #140 by @jimmielin * Update surface albedo units #181 by @mattldawson * don't set water species property for species that air_composition handles #185 by @peverwhee List all test failures: N/A
Fixes ESCOMP/CAM-SIMA#308
Requires a companion PR in CAM-SIMA to update the standard name of
tropp_slices
there as well: ESCOMP/CAM-SIMA#329