Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in errmsg, errflg in check_energy schemes #160

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Nov 20, 2024

Originator(s): @jimmielin

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Fixes #159. b4b changes to include errmsg, errflg in the check_energy schemes

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

Add errmsg, errflg (or set when not previously set) in check_energy schemes.

M       schemes/check_energy/check_energy_chng.F90
M       schemes/check_energy/check_energy_fix.F90
M       schemes/check_energy/check_energy_fix.meta
M       schemes/check_energy/check_energy_gmean/check_energy_gmean.F90
M       schemes/check_energy/check_energy_gmean/check_energy_gmean.meta
M       schemes/check_energy/check_energy_save_teout.F90
M       schemes/check_energy/check_energy_save_teout.meta
M       schemes/check_energy/check_energy_zero_fluxes.F90
M       schemes/check_energy/check_energy_zero_fluxes.meta
M       schemes/check_energy/dycore_energy_consistency_adjust.F90
M       schemes/check_energy/dycore_energy_consistency_adjust.meta

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

@jimmielin jimmielin added the cleanup This issue indicates an opportunity for code cleanup. label Nov 20, 2024
@jimmielin jimmielin self-assigned this Nov 20, 2024
@nusbaume nusbaume added the bug-fix This PR was created to fix a specific bug. label Nov 21, 2024
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jimmielin jimmielin merged commit 9cec536 into ESCOMP:development Nov 25, 2024
3 checks passed
jimmielin added a commit that referenced this pull request Dec 31, 2024
Tag name (The PR title should also include the tag name):
`atmos_phys0_07_001`
Originator(s): @jimmielin

List all `development` PR URLs included in this PR and a short
description of each:
* Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze
* Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze
* Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin
* Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze
* Add constituent tendency updater #111 by @peverwhee
* Add cloud optical calculations for use in TUV-x #167 by @mattldawson
* Add initialize_constituents scheme #149 by @peverwhee
* Add diagnostics to TJ2016 test schemes #170 by @peverwhee
* update "radians" to "rad" #173 by @peverwhee
* Solar zenith angle and Earth-Sun distance #171 by @mattldawson
* Update standard names for tropopause_find #140 by @jimmielin
* Update surface albedo units #181 by @mattldawson
* don't set water species property for species that air_composition handles #185 by @peverwhee

List all test failures: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug. cleanup This issue indicates an opportunity for code cleanup.
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants