Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUSICA TUVX scheme: create aerosol radiator, set_aerosol_optics_values #182

Merged
merged 24 commits into from
Jan 9, 2025
Merged

MUSICA TUVX scheme: create aerosol radiator, set_aerosol_optics_values #182

merged 24 commits into from
Jan 9, 2025

Conversation

dwfncar
Copy link
Collaborator

@dwfncar dwfncar commented Dec 17, 2024 •
edited by boulderdaze
Loading

Originator(s): @dwfncar

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/musica/tuvx/musica_ccpp_tuvx_aerosol_optics.F90
A       test/musica/tuvx/test_tuvx_aerosol_optics.F90

List all existing files that have been modified, and describe the changes:

M       schemes/musica/tuvx/musica_ccpp_tuvx.F90
M       schemes/musica/tuvx/musica_ccpp_tuvx_surface_albedo.F90
M       test/docker/Dockerfile.musica
M       test/docker/Dockerfile.musica.no_install
M       test/musica/tuvx/CMakeLists.txt

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

davidfillmore and others added 21 commits December 9, 2024 07:12
@davidfillmore
Start on musica_ccpp_tuvx_aerosol_optics.F90.
91fc2b3
@davidfillmore
Start on musica_ccpp_tuvx_aerosol_optics.F90.
333409c
@davidfillmore
Start on subroutine set_aerosol_optics_values.
ac0bb7a
@davidfillmore
Added aersol_visible_optical_depth.
6c8e31b
@davidfillmore
Set optical depth profile from host values.
f3456cc
@davidfillmore
Fixed type in function name.
45d159c
@davidfillmore
Adding create_aerosol_optical_depth_profile to musica_ccpp_tuvx.F90.
5482d4b
@davidfillmore
Merged development to 99-set-aer-opt-prop.
c05128e
@davidfillmore
Added function create_aersol_optics_radiator.
a30b8ab
@davidfillmore
Use create_aerosol_optics_radiator in musica_ccpp_tuvx.F90.
2cee56f
@davidfillmore
Start on set_aerosol_optics_values.
1b3b24d
@davidfillmore
Call radiator.set_optical_depths in aerosol optics.
88224b3
Set aerosol_optical_depths to 0.
ad2c4c6
Added num_streams to aerosol_asymmetry_factors.
d6b6b4a
Use 0.0_kind_phys.
11be8c5
Added aersol radiator.
9e81185
In muscica_ccpp_tuvx, add set_aerosol call.
6f9a420
@dwfncar
Start on test_tuvx_aerosol_optics.F90.
14d6b18
@dwfncar
Fixed call to set_aerosol_optics_values.
52106a7
@dwfncar
Fixed test_tuvx_aerosol_optics.F90.
6cc52df
@davidfillmore
Merged development.
2c4bce7
@dwfncar dwfncar marked this pull request as ready for review December 18, 2024 17:42
@dwfncar
Copy link
Collaborator Author

dwfncar commented Dec 18, 2024

See also NCAR/cam-sima-chemistry-data#4

boulderdaze
boulderdaze requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a small request.

schemes/musica/tuvx/musica_ccpp_tuvx_aerosol_optics.F90

contains

function create_aerosol_optics_radiator( height_grid, wavelength_grid, &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include descriptions for the function?

schemes/musica/tuvx/musica_ccpp_tuvx_aerosol_optics.F90 Outdated
end function create_aerosol_optics_radiator


subroutine set_aerosol_optics_values( radiator, &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include descriptions for the function?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include in the description a note about this temporarily setting optical properties to zero until aerosol optical property calculations are ported to CAM-SIMA?

@boulderdaze boulderdaze requested a review from jimmielin January 7, 2025 19:17
mattldawson
mattldawson approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just one minor suggestion

schemes/musica/tuvx/musica_ccpp_tuvx_aerosol_optics.F90 Outdated
end function create_aerosol_optics_radiator


subroutine set_aerosol_optics_values( radiator, &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include in the description a note about this temporarily setting optical properties to zero until aerosol optical property calculations are ported to CAM-SIMA?

jimmielin
jimmielin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwfncar!

@boulderdaze boulderdaze merged commit d4bd202 into development Jan 9, 2025
3 checks passed
@boulderdaze boulderdaze deleted the 99-set-aer-opt-prop branch January 9, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulderdaze boulderdaze boulderdaze approved these changes

@K20shores K20shores K20shores approved these changes

@mattldawson mattldawson mattldawson approved these changes

@jimmielin jimmielin jimmielin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dwfncar @jimmielin @mattldawson @K20shores @boulderdaze @davidfillmore