101 calculate no photolysis rate constants #183
+983
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull ZM 0.5 timestep removal into main
Replace original, locally-developed license with Apache 2.0 license.
Bring in new directory structure from development
Upgrading to atmos_phys0_06_000
Tag name (The PR title should also include the tag name): `atmos_phys0_07_000` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * #141 by @mattldawson @boulderdaze * #147 by @peverwhee * #144 by @mwaxmonsky * #151 by @mattldawson * #145 by @jimmielin List all test failures: N/A
K20shores
requested review from
boulderdaze,
nusbaume,
jimmielin,
cacraigucar,
mattldawson,
mwaxmonsky and
peverwhee
|
Hi @K20shores could you change the base branch of this PR to I'm happy to review once the PR is out of draft. Thanks! |
boulderdaze
requested changes
Jan 7, 2025
| @@ -0,0 +1,63 @@ | |||
| program test_tuvx_surface_albedo | |||
There was a problem hiding this comment.
Could you rename the program and adjust the spacing to use 2 instead of 3, as all the modules under musica scheme do?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
There are a number of TODOs I still need to figure out, and I'm not really sure how to test this properly. The paper detailing the implemented algorithm doesn't seem to list individual values for Js, and I'm not sure what values they used for their extra terrestrial flux, but that could be a potential testing avenue if we thinks its worth me tracking down values from references.