Add function for NO photolysis calculation #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
approved these changes
Jan 23, 2025
boulderdaze
changed the title
boulderdaze
commented
Jan 24, 2025
Comment on lines
+181
to
+182
| real(dk) :: delta_z(size(dry_air_density)+1) ! layer thickness (cm) | ||
| real(dk) :: jNO(size(dry_air_density)) ! final photolysis rate |
There was a problem hiding this comment.
Hi @K20shores, @mattldawson, what do you think about renaming these variables such as?
delta_z ->layer_thickness
jNO-> photolysis_rate_NO
boulderdaze
commented
Jan 24, 2025
Comment on lines
+189
to
+201
| N2_densities(1) = N2_densities(2) * 0.9_dk | ||
|
|
||
| call convert_mixing_ratio_to_molecule_cm3(constituents(:,O2_index), dry_air_density, molar_mass_O2, o2_dens(2:)) | ||
| o2_dens(1) = o2_dens(2) * 7.0_dk / ( height_at_interfaces(1) - height_at_interfaces(2) ) | ||
| call convert_mixing_ratio_to_molecule_cm3(constituents_O2, & | ||
| dry_air_density, MOLAR_MASS_O2, O2_densities(2:)) | ||
| O2_densities(1) = O2_densities(2) * 7.0_dk / ( height_at_interfaces(1) - height_at_interfaces(2) ) | ||
|
|
||
| call convert_mixing_ratio_to_molecule_cm3(constituents(:,O3_index), dry_air_density, molar_mass_O3, o3_dens(2:)) | ||
| o3_dens(1) = o3_dens(2) * 7.0_dk / ( height_at_interfaces(1) - height_at_interfaces(2) ) | ||
| call convert_mixing_ratio_to_molecule_cm3(constituents_O3, & | ||
| dry_air_density, MOLAR_MASS_O3, O3_densities(2:)) | ||
| O3_densities(1) = O3_densities(2) * 7.0_dk / ( height_at_interfaces(1) - height_at_interfaces(2) ) | ||
|
|
||
| call convert_mixing_ratio_to_molecule_cm3(constituents(:,NO_index), dry_air_density, molar_mass_NO, no_dens(2:)) | ||
| no_dens(1) = no_dens(2) * 0.9_dk | ||
| call convert_mixing_ratio_to_molecule_cm3(constituents_NO_photolysis(:,index_NO), & | ||
| dry_air_density, MOLAR_MASS_NO, NO_densities(2:)) | ||
| NO_densities(1) = NO_densities(2) * 0.9_dk |
There was a problem hiding this comment.
Hi @mattldawson, @K20shores, I checked that in the CAM code, these (7.0_dk, 0.9_dk, and so on) also appear to be magic numbers without explanation. Is there a way to figure out what they represent so we can define them as constexpr variables?
There was a problem hiding this comment.
I also don't know. I wonder if they are scale heights, but I don't understand why they would be different. The original paper also didn't really indicate anything about this. We may have to ask Doug.
There was a problem hiding this comment.
Great, I asked him about it
K20shores
approved these changes
Jan 24, 2025
boulderdaze
merged commit 5399a16
into
101-calculate-no-photolysis-rate-constants
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.