add plotting for points without lat/long #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good if the user can still just not plot the locations with no lat lng data. I'll merge this and then add a new PR to show what I mean. |
|
D'Oh! Yes, great point - 'Don't plot' should be an additional option. If we plot them at the North Pole, they will drop off the current projection, or we could keep them as NA in case we build in other projections in the future, I guess.
Thanks!
Neal
…________________________________
From: Matthew Grainger ***@***.***>
Sent: 13 April 2022 09:27
To: ESHackathon/eviatlas ***@***.***>
Cc: nealhaddaway ***@***.***>; Author ***@***.***>
Subject: Re: [ESHackathon/eviatlas] add plotting for points without lat/long (PR #90)
It would be good if the user can still just not plot the locations with no lat lng data. I'll merge this and then add a new PR to show what I mean.
—
Reply to this email directly, view it on GitHub<#90 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKOBNXDSOJOYCCDDE5DAR2DVE2HRRANCNFSM5TIF5GGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #76 - done by prompting the user to select one of several predefined locations.