Redo autoconf #26
Redo autoconf #26
Conversation
There was a problem hiding this comment.
There seem to be a lot of changes that are unrelated to the stated purpose of this PR (redo autoconf). If that is a correct assessment, it would be helpful to add those items to the PR description or move these changes to a different branch for later inclusion (some seems unfinished, much is commented out).
|
Those changes were removed in the previous PR - this one just needed to be merged to master. |
Thanks, it can be hard to figure out what the code will look like when the PR is against an old hash. |
|
I have tested on derecho, using spack on derecho and the github action is also installing and running make check. thank you |
| @@ -0,0 +1,674 @@ | |||
| GNU GENERAL PUBLIC LICENSE | |||
There was a problem hiding this comment.
What is the purpose of a file called COPYING with the GPL in it? This software is covered by the BSD 3-clause.
There was a problem hiding this comment.
This file was generated by automake and I didn't look at it too closely. I will correct.
Redo autoconf build system to be more standard.