Constant PVT Table #416
Constant PVT Table #416
Conversation
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
ac427ae to
175f770
Compare
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
0962be3 to
79b381b
Compare
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
707e8e7 to
eb832ef
Compare
caio-ramos
requested review from
BeneBr,
alexandrebbruno,
marinhoeng and
eniohayashi
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
9243a0b to
eb832ef
Compare
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
dcbfd0f to
8982476
Compare
| oil_specific_heat = attrib_scalar(default=Scalar(4181.3, "J/kg.K")) | ||
| water_specific_heat = attrib_scalar(default=Scalar(4181.3, "J/kg.K")) |
There was a problem hiding this comment.
Are specific heat values really identical for oil and water?
There was a problem hiding this comment.
Actually, I'm not sure. To define these values, I adopted the values already available in the arguments of the create_constant function
| gas_oil_surface_tension = attrib_scalar(default=Scalar(7.197e-2, "N/m")) | ||
| gas_water_surface_tension = attrib_scalar(default=Scalar(7.197e-2, "N/m")) | ||
| oil_water_surface_tension = attrib_scalar(default=Scalar(7.197e-2, "N/m")) |
There was a problem hiding this comment.
Is there some motive to consider the same value for surface tension for all the phases?
There was a problem hiding this comment.
Not sure, the reason why these values are here is the same as for oil_specific_heat and water_specific_heat
| :"kW.h/tonUK": kilowatt hours/U.S. ton | ||
| :"kW.h/tonUS": kilowatt hours/U.S. ton |
There was a problem hiding this comment.
Are descriptions for tonUK and tonUS identical?
There was a problem hiding this comment.
These descriptions are defined based on the barril repository. Looking at the specific energy unit database ( barril/units/posc), we can see that they are identical, which I believe is incorrect.
There was a problem hiding this comment.
I created the issue ESSS/barril#165 in the barril repository to report this problem..
There was a problem hiding this comment.
FYI we do not look at the repository issues when we plan our sprints, so if you want to see that fixed eventually, you need to create a JIRA issue.
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
a020699 to
c0d1796
Compare
|
Here are the features required to allow https://github.com/ESSS/alfasim/pull/796 work properly.
A new PVT model description is added, so user-defined properties can be stored and used to generate a PVT Table with constant properties.