Implement Signal #1012
Open
Implement Signal #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empty when disconnecting a signal
jwellbelove
reviewed
Jan 13, 2025
| ///\todo Support for return types other than void (aggregate etc.) | ||
| //*************************************************************************** | ||
| template <typename T, size_t LENGTH, typename TSlot = etl::delegate<T>> | ||
| class signal final |
There was a problem hiding this comment.
If this class is meant to support C++03 then you should use ETL_FINAL.
You can check basic compatibility from C++03 to C++20 by running the script etl/test/run-syntax-checks.sh on Linux. You need both GCC and clang installed.
There was a problem hiding this comment.
My primary goal was to be c++14 compliant since that is what I use, but I tried to be as lower compliant as possible. I didn't know that script existed, thanks, I'll run it and see what I find :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of signal for #666
I implemented something very similar to this on other software and thought this would be useful for this project. I would like to use this version over my other implementation.
Some other things that could be added at some point is being able to pass in an aggregator or some kind of module that can act on all the signals (think sumnation, product, etc).