Add contains() method to etl::unordered_map and etl::unordered_set #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#990-Add-contains-method-to-etl-unordered_map-and-etl-unordered_set
|
Are you able to add the same changes to |
|
I am already working on transparent comparitors for the unordered containers. |
…ultimap Use predefined variables in UT Move contains() method to correct place in etl::unordered_set
|
Added |
adejewski
force-pushed
the
add-contains-to-unordered-map-and-unordered-set
branch
from
fca5100 to
29de7b2
Compare
jwellbelove
merged commit 602261c
into
ETLCPP:pull-request/#990-Add-contains-method-to-etl-unordered_map-and-etl-unordered_set
63 checks passed
jwellbelove
added a commit
that referenced
this pull request
Dec 19, 2024
…map-and-etl-unordered_set' into development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed we are missing contains method in etl::unordered_map and etl::unordered_set, this PR fixes that. What is more, I think we are missing transparent comparators in both of those classes, I can look into that later if you want.