Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: direct support for __dump_gcov #1005

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feature: direct support for __dump_gcov #1005

merged 4 commits into from
Jan 16, 2025

Conversation

a-w50
Copy link
Contributor

@a-w50 a-w50 commented Jan 15, 2025

  • the previous implementation for dumping gcov statistics wasn't robust enough
  • now, __dump_gcov is called directly from the signal handler and then _exit is called - this guarantees dumping of gcov statistics and immidiate module exit

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@@ -86,7 +86,7 @@ ext-mbedtls:
# everest-testing and ev-dev-tools
everest-utils:
git: https://github.com/EVerest/everest-utils.git
git_tag: v0.4.4
git_tag: 54c4793d8494c2b66867c281e499c35a88c72624
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to a hash on main before this is merged

a-w50 added 4 commits January 16, 2025 15:55
- the previous implementation for dumping gcov statistics wasn't robust
  enough
- now, `__dump_gcov` is called directly from the signal handler and then
  `_exit` is called - this guarantees dumping of gcov statistics and
  immidiate module exit

Signed-off-by: aw <[email protected]>
Signed-off-by: aw <[email protected]>
Signed-off-by: aw <[email protected]>
@a-w50 a-w50 force-pushed the feature/target_coverage branch from d3850f3 to 101a410 Compare January 16, 2025 14:55
@a-w50 a-w50 merged commit 3bf3834 into main Jan 16, 2025
11 checks passed
@a-w50 a-w50 deleted the feature/target_coverage branch January 16, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants