Fix debug output of EV max voltage #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
hikinggrass
approved these changes
Oct 11, 2024
hikinggrass
added
the
include-in-release
a-w50
reviewed
Oct 11, 2024
Comment on lines
1395
to
1401
| float ev_max_voltage = 500.; | ||
|
|
||
| if (ev_info.maximum_voltage_limit.has_value()) { | ||
| EVLOG_info << "EV reports " << ev_info.maximum_voltage_limit.has_value() << " V as maximum voltage"; | ||
| EVLOG_info << "EV reports " << ev_info.maximum_voltage_limit.value() << " V as maximum voltage"; | ||
| ev_max_voltage = ev_info.maximum_voltage_limit.value(); | ||
| } else { | ||
| EVLOG_error << "CableCheck: Did not receive EV maximum voltage, falling back to 500V"; |
There was a problem hiding this comment.
I would probably add a constant for the 500V, like DEFAULT_MAXIMUM_VOLTAGE. Otherwise, if this gets changed, chances are likely that the EVLOG_error still logs 500V. One may also use
const auto ev_max_voltage = ev_info.maximum_voltage_limit.value_or(DEFAULT_MAXIMUM_VOLTAGE) then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review