-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce EVSE Manager configuration option for failing charging if t… #993
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the added errors which now cause the evse manager to become Inoperative to the documentation in the doc.rst
…he powermeter has errors Signed-off-by: florinmihut <[email protected]>
Signed-off-by: florinmihut <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: florinmihut <[email protected]>
03fbac4
to
add88f3
Compare
Currently, a transaction can never be started if I think we should check everest-core/modules/EvseManager/Charger.cpp Line 1206 in add88f3
and we should not return early in case fail_on_powermeter_errors is false so that we can still start the transaction.
This would mean the
What do you think @corneliusclaussen @florinmihut ? I would suggest that we move the changes of the powermeter documentation PR into this PR. |
Signed-off-by: florinmihut <[email protected]>
Made the requested changes and add the documentation as mermaid files. |
…he powermeter has errors
Describe your changes
Issue ticket number and link
Checklist before requesting a review