Correct the tags output by the Docker metadata action #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Moore <[email protected]>
drmrd
changed the title
|
@shankari: This fix appears to be doing the trick. If you approve, feel free to merge. |
This was referenced Dec 6, 2023
Closed
shankari
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Interesting, I would not have expected this to work. type=semver appears to only be invoked on a push tag event
https://github.com/docker/metadata-action#typesemver
Will be used on a [push tag event](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push) and requires a valid [semver](https://semver.org/) Git tag, but you can also use a custom value through value attribute.
However, I do see that it seems to work in the PR, so I will go ahead and merge optimistically.
If it doesn't work, I think you will:
- need a
type=refand figure out how to pass in the value, or - manually tag the docker image instead of using the metadata action (for simplicity)
- need to change our process to tag releases (which is not necessarily a bad thing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the
docker/metadata-actionin our CI/CD workflow so that the tag in our.envfile is used to label new Docker images.Closes #12