-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ISO 15118-2 DC demo with -2 message logs #3
Update the ISO 15118-2 DC demo with -2 message logs #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a temporary fix. However, note that the config here is one that I copied from everest-core
to get the demo to work. We should consider submitting the new config to everest-core
or wherever we end up with config examples.
@hikinggrass, this is a change to the node-red config in the demo repo. The original file is copied over from everest-core
, where there are a lot of sample configs. I anticipate that the set of sample configs will grow significantly, as we do more end-to-end testing with various configurations.
We might want to consider where they should live in the long term and how to make it easy for others to discover them.
I have also filed an internal issue to track the potential improvements (toggle on/off, toggle encoded/decoded)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no packages in everest, and there will not be any until the build process is finalized
The only currently built packages are here:
https://github.com/orgs/US-JOET/packages
@drmrd are you sure that this works as checked in? I tried testing it and I wasn't able to launch the node-red server or the UI Logs from the launch
|
@shankari I think you have a typo in the browser. You will want to access |
Ooops! This is why I shouldn't test at 10pm. This does launch now, but it doesn't include the new logging functionality, since the image has not been updated. |
@shankari if I am reading this correctly the creation of images looks to be postponed until the PR is merged. This is so that there is not functionality within the running container that relies on the code in the PR. To test a PR's changes locally you can build that image yourself when pulling down the code. I am leaning toward adding a |
@couryrr-afs as you can see from the action and the issue, the current flow is:
Yes, this is clunky. We should fix it even in the short term |
Closing this PR in favor of US-JOET#3 to accommodate existing Docker build process. |
Re-opening for the time being, with the intent being to finish a review after we update the CI in #10. |
@drmrd if you can resolve the merge conflict and bump up the version, this one has been approved and is good to go. |
493348c
to
994ba30
Compare
Signed-off-by: Daniel Moore <[email protected]>
994ba30
to
2826f23
Compare
@shankari: I believe this PR is updated and ready to go. |
This PR aligns the demo with what we've been showing during industry outreach events. Changes to the ISO 15118-2 DC demo's Node-Red flows result in all ISO 15118-2-related messages being displayed in a table. The actual request and response messages remain EXI-encoded. A V2G decoder (such as this one based on RISE-V2G) can then be used to decode these messages.
Future improvements could include incorporating a Node-based V2G decoder into the dashboard or to log un-encoded V2G messages more directly. The message types that are published during the demo's 15118-2 request-response message sequence(s) are displayed above the table in real-time, as well.