Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/fk revise package names #105

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Refactor/fk revise package names #105

merged 4 commits into from
Nov 30, 2023

Conversation

klemmpnx
Copy link
Contributor

Refactor the everest-testing package:

  • rename "visitors" to "strategies" (since the implementations are not dispatching between different classes but always apply to the same "config", which actually better fits a simpler Strategy pattern; as discussed in spatial)
  • make _configuration package protected and only expose some classes through init (simplify interface / protect for version changes)

@klemmpnx klemmpnx self-assigned this Nov 27, 2023
@klemmpnx
fix linter issues
ea9297f 
Signed-off-by: Fabian Klemm <[email protected]>
valentin-dimov
valentin-dimov suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@valentin-dimov valentin-dimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also adapt the README for everest-testing with the new names.

@klemmpnx
adjust readme
81340f1 
Signed-off-by: Fabian Klemm <[email protected]>
valentin-dimov
valentin-dimov approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@valentin-dimov valentin-dimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@klemmpnx klemmpnx merged commit 9ff3489 into main Nov 30, 2023
6 checks passed
@klemmpnx klemmpnx deleted the refactor/fk-revise-package-names branch November 30, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentin-dimov valentin-dimov valentin-dimov approved these changes

Assignees

@klemmpnx klemmpnx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klemmpnx @valentin-dimov