Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "clang-format version 16.0.0"-bug #119

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

andistorm
Copy link
Contributor

@andistorm andistorm commented Feb 28, 2024

  • Use clang-format version 15.0.6
  • Use clang-format from package manager
  • Move run-clang-format script to everest-utils

related to EVerest/everest-ci#11 (comment)

* Use clang-format version 15.0.6
* Use clang-format from package manager
* Move run-clang-format script to everest-utils

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm self-assigned this Feb 28, 2024
* Add input in reusable workflow `deploy-single-docker-image'
* Add input for workflow_dispatch in workflow `deploy-all-docker-images`

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Copy link
Contributor Author

The image is deployed here: https://github.com/orgs/EVerest/packages/container/everest-clang-format/184517158?tag=bugifx-use-stable-clang-format-version

And can be tested by using the corresponding tag

@andistorm andistorm marked this pull request as ready for review February 28, 2024 11:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a reference to our fork or the upstream repo from where this originates

Copy link
Contributor Author

@andistorm andistorm Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added a reference to the upstream repo. So we could archive our fork

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm requested a review from hikinggrass March 15, 2024 10:12
@andistorm andistorm merged commit 03b3d35 into main Mar 15, 2024
5 of 6 checks passed
@andistorm andistorm deleted the bugifx/use-stable-clang-format-version branch March 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants