Bugfix/array type support in subscribe #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djchhp
approved these changes
Jun 21, 2024
corneliusclaussen
force-pushed
the
bugfix/array_type_support_in_subscribe
branch
from
d23f42a to
bfc1581
Compare
- the json array object has been casted to `nlohman::json::array` so far, instead of `std::vector<ItemType>` for subscription - this commit introduces some code duplication, as it copies the handling from the `_gather_cmds` implementation -- this should be refactored - NOTE: the array of enum handling has not been checked bugfix: add correct type within public publish interface - NOTE: all of this different type if/elseing needs to be refactored if it should stay maintainable Signed-off-by: aw <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/array_type_support_in_subscribe
branch
from
bfc1581 to
3ed2262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed array types in vars