Support for returning array / std::vector in EVerest interfaces #79
Conversation
| @@ -81,6 +81,12 @@ public: | |||
| {% elif 'object_type' in cmd.result %} | |||
| json retval_json = result.value(); | |||
| {{ result_type(cmd.result) }} retval = retval_json; | |||
| {% elif 'array_type' in cmd.result %} | |||
| auto array = {{ var_to_cpp(cmd.result) }}(result.value()); | |||
There was a problem hiding this comment.
I think this line here shouldn't be necessary. It should also work if you use result.value() inside the for loop instead of array
Pietfried
force-pushed
the
pg-fix-vector-return-type
branch
from
3f95bd9 to
7a10619
Compare
…ion of default return value {} for vector
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: aw <[email protected]> Signed-off-by: Fabian Klemm <[email protected]>
klemmpnx
force-pushed
the
pg-fix-vector-return-type
branch
from
7a10619 to
c91710b
Compare
Signed-off-by: Fabian Klemm <[email protected]>
|
rebased that, bumped the version and did a minor correction in the helpers.py; about the discussion above: I think Piet already had addressed the comment (I am not sure about the mentioned "for loop", however this I applies in the current template for enums and I assume the construction via begin()....end() is better suited here) |
Co-authored-by: Andreas Heinrich <[email protected]> Signed-off-by: Fabian Klemm <[email protected]>
|
@a-w50 : as discussed today, tested on branch refactor/ocpp-interface with config "config-sil-ocpp-custom-extension.yaml" that spins up an "OCPPExtensionExample" module (which then uses the auto-generated caller code and requests a a vector of elements) - this seems to work fine! |
There was a problem hiding this comment.
Looks good to me, will test/use it in my use case EVerest/everest-core#447
fixed generation of vector return type in interface and allow generation of default return value {} for vector