Skip to content

Commit

Permalink
minor #6750 Add some more missing types (javiereguiluz)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.x branch.

Discussion
----------

Add some more missing types

Commits
-------

dac7eea Add some more missing types
  • Loading branch information
javiereguiluz committed Jan 21, 2025
2 parents fe672a4 + dac7eea commit af278aa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/Dto/CrudDto.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public function setEntityFqcn(string $entityFqcn): void
$this->entityFqcn = $entityFqcn;
}

public function getEntityLabelInSingular($entityInstance = null, $pageName = null): TranslatableInterface|string|null
public function getEntityLabelInSingular(/* ?object */ $entityInstance = null, /* ?string */ $pageName = null): TranslatableInterface|string|null
{
if (null === $this->entityLabelInSingular) {
return null;
Expand All @@ -138,7 +138,7 @@ public function setEntityLabelInSingular($label): void
$this->entityLabelInSingular = $label;
}

public function getEntityLabelInPlural($entityInstance = null, $pageName = null): TranslatableInterface|string|null
public function getEntityLabelInPlural(/* ?object */ $entityInstance = null, /* ?string */ $pageName = null): TranslatableInterface|string|null
{
if (null === $this->entityLabelInPlural) {
return null;
Expand All @@ -162,7 +162,7 @@ public function setEntityLabelInPlural($label): void
$this->entityLabelInPlural = $label;
}

public function getCustomPageTitle(?string $pageName = null, $entityInstance = null, array $translationParameters = [], ?string $domain = null): ?TranslatableInterface
public function getCustomPageTitle(?string $pageName = null, /* ?object */ $entityInstance = null, array $translationParameters = [], ?string $domain = null): ?TranslatableInterface
{
$title = $this->customPageTitles[$pageName ?? $this->pageName];
if (\is_callable($title)) {
Expand Down

0 comments on commit af278aa

Please sign in to comment.