Fix an edge-case about pretty URLs and cache warm up #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6680.
Thanks to the debugging information provided in #6680 I could implement this solution.
The first change is that we no longer use
Routeoptions but defaults, because defaults are mapped toRequestattributes and the options are not available unless you instantiate theRouteobject, which is not possible in our scenario. This change simplifies code a bit.The other change, and the real solution of the reported error, is that we know regenerate the admin route cache if we know that the backend uses pretty URLs but the cache doesn't contain the admin routes.