Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

fix meta description use page contents #198

Conversation

flora8984461
Copy link
Contributor

@flora8984461 flora8984461 commented Jan 12, 2021

#197

I think we need .Params to refer correctly the page params

reference:
https://gohugo.io/variables/page/

Signed-off-by: Yi Liu [email protected]

@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for eclipsefdn-hugo-solstice-theme ready!

🔨 Explore the source changes: ea66b94

🔍 Inspect the deploy logs: https://app.netlify.com/sites/eclipsefdn-hugo-solstice-theme/deploys/5ffe1a144b4c7b00081a4379

😎 Browse the preview: https://deploy-preview-198--eclipsefdn-hugo-solstice-theme.netlify.app

@flora8984461 flora8984461 marked this pull request as ready for review January 12, 2021 17:34
Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using .Summary was intentional, as it meant we didn't need to interact with the code to generate descriptions for every page. This change would force every page to have explicit summaries or descriptions which isn't ideal. Is the fix here to maybe add an end summary tag on the page in question?

Update: Read the issue again, and realized we are trying to strip it out rather than fix this one instance. This is the nuclear option and we should investigate another fix before going this route.

@flora8984461 flora8984461 marked this pull request as draft January 13, 2021 14:14
@flora8984461
Copy link
Contributor Author

flora8984461 commented Jan 13, 2021

Using .Summary was intentional, as it meant we didn't need to interact with the code to generate descriptions for every page. This change would force every page to have explicit summaries or descriptions which isn't ideal. Is the fix here to maybe add an end summary tag on the page in question?

Update: Read the issue again, and realized we are trying to strip it out rather than fix this one instance. This is the nuclear option and we should investigate another fix before going this route.

Ah, IC, I thought it was bug... So it's by intent to use the contents within the page. Just want to filter out the shortcode 🤔

I posted a question in Hugo forum, https://discourse.gohugo.io/t/is-there-a-faster-way-to-escape-or-filter-out-the-shortcode/30618

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants