RSSI Model Locator: Add TX Power & Haptic Feedback #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the current TX power so that people can see if they are on 25mW or not
* Now uses haptic feedback * Text has been moved to not overlap
AegisCrusader
changed the title
AegisCrusader
changed the title
0.5 -> 0.6
|
@offer-shmuely Do you have any preference for the version number change? |
|
the changes looks ok also, the haptic default should be false |
- Haptic now disabled by default - Set power message disappears if the power is correct
|
Changes have been made! Haptic is disabled by default and the message disappears when 25mW is the current power. |
However has not been tested for screen layout, etc
|
LGTM... thank you for your contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the current TX power so that people can see if they are on 25mW or not when using the locator. Additionally adds haptic feedback for those hard of hearing or those who just like it