-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getLinkTarget for MEI 5 work titles #505
Conversation
Only from looking at it (i.e. without testing) that looks ok. Yet I wonder whether the whole conditional is overly complicated and something like |
at the community meeting 2024-12-18 we agreed to add inline documentation regarding MEI versions for the v1.0.0 release @bwbohl and to have a more complex solution in a later release |
816a3d9
to
c807e7a
Compare
Ok, I tried to simplify and globalise a bit in the @riedde please test with your dataset that has |
1999684
to
65d1201
Compare
531900a
to
babd1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased locally and tested with Klarinettenquintett and Pintos
be aware that this will fail for MEI prior v4
Thsi removes doubled 'type' identification that already happens in the $type variable which gets submitted to the call of the getWindowTitle function
… if nothing else works
since the return value of `eutil:getDoc#1` in https://github.com/Edirom/Edirom-Online/blob/babd1c6076ba58214b85a9891c3c2215d9d1c9d6/add/data/xql/getLinkTarget.xql#L278 might be the empty sequence this should be reflected in the function signatures that consume this $doc variable.
Co-authored-by: Peter Stadler <[email protected]>
8f7738d
to
d065dfd
Compare
Description, Context and related Issue
Remove
mei:titleStmt
when determining the title of the work because in MEI 5mei:title
is a direct child ofmei:work
Closes #337
How Has This Been Tested?
With a BAZ-GA MEI 5 work.
Types of changes
Overview
I have performed a self-review of my code, according to the style guide
I have read the CONTRIBUTING document.
I have added tests to cover my changes at testing
All new and existing tests passed.
--> will know when the PR has run its tests ;-)